Skip to content

Fix and add tests for Jas Violations #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
attiasas merged 6 commits into from
Jan 2, 2025
Merged

Fix and add tests for Jas Violations #273

attiasas merged 6 commits into from
Jan 2, 2025

Conversation

@attiasas
Copy link
Contributor

@attiasas attiasas commented Dec 31, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

depends on:

@attiasas attiasas added the ignore for release Automatically generated release notes label Dec 31, 2024
@attiasas attiasas marked this pull request as ready for review January 1, 2025 08:17
@attiasas attiasas requested a review from orz25 January 1, 2025 08:20
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 1, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 1, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 1, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 1, 2025
@github-actions
Copy link

github-actions bot commented Jan 1, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

@github-actions
Copy link

github-actions bot commented Jan 1, 2025

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security 0.00% (ø)
Coverage by file

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/audit_test.go
  • github.com/jfrog/jfrog-cli-security/xsc_test.go

@attiasas attiasas merged commit 33f766f into jfrog:dev Jan 2, 2025
56 checks passed
@attiasas attiasas deleted the fix_jas_git_repo_project_tests branch January 2, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@orz25 orz25 orz25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ignore for release Automatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@attiasas @orz25